feat: Date formats for date range picker #3837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
force-pushed
the
feat-date-range-picker-custom-formats
branch
3 times, most recently
from
75787bc to
83c1fa6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3837 +/- ##
==========================================
+ Coverage 97.21% 97.22% +0.01%
==========================================
Files 844 844
Lines 24561 24586 +25
Branches 8660 8672 +12
==========================================
+ Hits 23877 23904 +27
+ Misses 677 675 -2
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan-kot
force-pushed
the
feat-date-range-picker-custom-formats
branch
from
83c1fa6 to
f031e83
Compare
| const dateInputPlaceholder = isMonthPicker ? 'YYYY/MM' : 'YYYY/MM/DD'; | ||
| const showTimeInput = !dateOnly && !isMonthPicker; | ||
|
|
||
| const parsedDateInputFormat = dateInputFormat; |
There was a problem hiding this comment.
Nitpick (not blocking): You could use the dateInputFormat directly and remove this line as dateInputFormat stays as it is..
johannes-weber
previously approved these changes
Sep 12, 2025
johannes-weber
previously approved these changes
Sep 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
johannes-weber
approved these changes
Sep 16, 2025
at-susie
pushed a commit
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements date input formats for date range picker calendar date inputs.
Docs: [DvXYAOkww6To]
Same changes in date picker: #3719
Same changes in date input: #3686
Original implementation: #3555
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.