Skip to content

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Sep 5, 2025

Description

Putting a popover inside a key meant that the dismiss button was nested inside the <label> of the key, and clicking on that counted as clicking on the button and the popover would just reopen. I don't think we need the label here; the <dt>/<dd> already creates a relationship between the key and the value, more isn't needed here.

Related links, issue #, if available: AWSUI-61213

How has this been tested?

Just a simple element change, relying on existing tests to not fail.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot force-pushed the fix-interactive-in-key-value-pair branch from 5ddc269 to 4d3e4ca Compare September 5, 2025 15:52
@avinashbot avinashbot marked this pull request as ready for review September 5, 2025 15:53
@avinashbot avinashbot requested a review from a team as a code owner September 5, 2025 15:53
@avinashbot avinashbot requested review from patrixd and removed request for a team September 5, 2025 15:53
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (fdbe231) to head (4d3e4ca).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3845   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         844      844           
  Lines       24515    24515           
  Branches     8648     8648           
=======================================
  Hits        23815    23815           
  Misses        651      651           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot avinashbot requested review from a team and ernst-dev and removed request for patrixd and a team September 9, 2025 14:25
@avinashbot avinashbot added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit 7c40992 Sep 10, 2025
66 of 67 checks passed
@avinashbot avinashbot deleted the fix-interactive-in-key-value-pair branch September 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants