Skip to content

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Sep 5, 2025

Description

element.scrollIntoView() is not element.scrollIntoViewIfNeeded(), but element.scrollIntoViewIfNeeded() is deprecated/non-standard. Rather than doing anything weird, I just used a slightly different strategy for visually hiding elements that doesn't move the input way off screen.

Related links, issue #, if available: AWSUI-61214

How has this been tested?

Integration test.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (979d270) to head (95b8758).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3847      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files         844      844              
  Lines       24549    24548       -1     
  Branches     8658     8657       -1     
==========================================
- Hits        23845    23844       -1     
  Misses        697      697              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot avinashbot marked this pull request as ready for review September 9, 2025 13:29
@avinashbot avinashbot requested a review from a team as a code owner September 9, 2025 13:29
@avinashbot avinashbot requested review from taheramr and removed request for a team September 9, 2025 13:29
@avinashbot avinashbot added this pull request to the merge queue Sep 10, 2025
Merged via the queue into main with commit 3b13693 Sep 10, 2025
38 checks passed
@avinashbot avinashbot deleted the file-input-focus branch September 10, 2025 13:50
TrevorBurnham pushed a commit to TrevorBurnham/cloudscape-components that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants