Skip to content

Conversation

georgylobko
Copy link
Member

@georgylobko georgylobko commented Sep 12, 2025

Description

This PR addresses a recent regression causes a new left drawer's trigger to reduce right triggers' container size. This PR sets the size of the container explicitly.

Ran screenshot tests in my dev pipeline - no diff.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (d1c8b7f) to head (629108d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3854   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         844      844           
  Lines       24586    24586           
  Branches     8672     8672           
=======================================
  Hits        23904    23904           
  Misses        675      675           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgylobko georgylobko force-pushed the fix/drawers-triggers-size branch from f58967a to 629108d Compare September 16, 2025 12:53
@georgylobko georgylobko marked this pull request as ready for review September 16, 2025 13:48
@georgylobko georgylobko requested a review from a team as a code owner September 16, 2025 13:48
@georgylobko georgylobko requested review from cansuaa and just-boris and removed request for a team September 16, 2025 13:48
@georgylobko georgylobko added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit a4a2f4a Sep 17, 2025
38 checks passed
@georgylobko georgylobko deleted the fix/drawers-triggers-size branch September 17, 2025 09:30
at-susie pushed a commit that referenced this pull request Sep 17, 2025
just-boris added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants