Skip to content

Conversation

TrevorBurnham
Copy link
Contributor

Description

@just-boris noticed test failures when he did a dry run against cloudscape-design/component-toolkit#154, which removes the ResizeObserver polyfill used by the useResizeObserver hook. This PR updates the affected tests to make them compatible with that change.

How has this been tested?

I ran the unit test against the component-toolkit changes locally. I was unable to run the integration test, but @just-boris reported that the issue was that 3 resize observations occurred instead of 2. As he described it, the purpose of the assertion is to prevent infinite resize loops.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TrevorBurnham TrevorBurnham requested a review from a team as a code owner September 15, 2025 22:05
@TrevorBurnham TrevorBurnham requested review from teodoranemes and removed request for a team September 15, 2025 22:05
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.21%. Comparing base (08da1c8) to head (6109e57).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3867   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         844      844           
  Lines       24561    24561           
  Branches     8660     8661    +1     
=======================================
  Hits        23877    23877           
+ Misses        677      635   -42     
- Partials        7       49   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris added this pull request to the merge queue Sep 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2025
@just-boris just-boris added this pull request to the merge queue Sep 16, 2025
Merged via the queue into cloudscape-design:main with commit ac78196 Sep 16, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants