Skip to content

Conversation

just-boris
Copy link
Member

Description

Fixing a regression after resize observer switch: cloudscape-design/component-toolkit#154

Related links, issue #, if available: n/a

How has this been tested?

  • Locally
  • Because the regression was only in Firefox, not testable in the integration tests. Screenshot tests capture it (that's how the issue was detected)
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner September 16, 2025 18:52
@just-boris just-boris requested review from jperals and removed request for a team September 16, 2025 18:52
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (4cb9a71) to head (2ba1862).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3871   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         844      844           
  Lines       24595    24595           
  Branches     8676     8676           
=======================================
  Hits        23913    23913           
  Misses        675      675           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit ea385ed Sep 17, 2025
89 of 96 checks passed
@just-boris just-boris deleted the table-width-calc branch September 17, 2025 09:11
at-susie pushed a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants