Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support silentmode to mute engine log #745

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Apr 24, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

支持安静模式关闭 engine 的 log

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: support silentmode to mute engine log
zh(optional): 支持安静模式关闭 engine 的 log

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

cloudwego/cloudwego.github.io#632

@Duslia Duslia requested review from a team as code owners April 24, 2023 04:48
@welkeyever
Copy link
Member

加一个文档更新的 pr 链过来吧:https://www.cloudwego.io/zh/docs/hertz/tutorials/observability/log/ ;简单说明一下新功能。

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.06 ⚠️

Comparison is base (4a6d3b1) 75.72% compared to head (f4fca03) 75.67%.

❗ Current head f4fca03 differs from pull request most recent head db90c32. Consider uploading reports for the commit db90c32 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
- Coverage    75.72%   75.67%   -0.06%     
===========================================
  Files           97       97              
  Lines         9464     9468       +4     
===========================================
- Hits          7167     7165       -2     
- Misses        1849     1853       +4     
- Partials       448      450       +2     
Impacted Files Coverage Δ
pkg/common/hlog/hlog.go 80.00% <ø> (ø)
pkg/common/hlog/system.go 80.88% <0.00%> (-5.06%) ⬇️
pkg/route/engine.go 60.54% <0.00%> (ø)
pkg/protocol/multipart.go 77.21% <50.00%> (-2.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/common/hlog/system.go Outdated Show resolved Hide resolved
welkeyever
welkeyever previously approved these changes Apr 27, 2023
@welkeyever welkeyever merged commit 2e9df0d into cloudwego:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants