-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MIME consts #776
Conversation
just add some commonly used MIME types |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #776 +/- ##
========================================
Coverage 75.66% 75.66%
========================================
Files 97 97
Lines 9477 9477
========================================
Hits 7171 7171
Misses 1856 1856
Partials 450 450 ☔ View full report in Codecov by Sentry. |
Please follow the pr template and complete the information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
@cqqqq777 The unit test seems to have some MIME content-type strings, would you like to help replace them together? |
ok, I need some time. |
may be some omissions, because there are too many unit test code |
ok |
@cqqqq777 This is great and is what users need right now. But can we provide a document like fiber to help users know that we provide these constants. refer to https://docs.gofiber.io/api/constants . |
What type of PR is this?
feat
Check the PR title.
<type>(optional scope): <description>
.(Optional) Translate the PR title into Chinese.
新增 MIME 常量
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: add MIME consts
zh(optional): 新增 MIME 常量
(Optional) Which issue(s) this PR fixes:
#754
(Optional) The PR that updates user documentation: