Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MIME consts #776

Merged
merged 5 commits into from
May 22, 2023
Merged

feat: add MIME consts #776

merged 5 commits into from
May 22, 2023

Conversation

cqqqq777
Copy link
Contributor

@cqqqq777 cqqqq777 commented May 11, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

新增 MIME 常量

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add MIME consts
zh(optional): 新增 MIME 常量

(Optional) Which issue(s) this PR fixes:

#754

(Optional) The PR that updates user documentation:

@cqqqq777 cqqqq777 requested review from a team as code owners May 11, 2023 13:20
@cqqqq777
Copy link
Contributor Author

just add some commonly used MIME types

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (56411f8) 75.66% compared to head (f101d61) 75.66%.

❗ Current head f101d61 differs from pull request most recent head 6735831. Consider uploading reports for the commit 6735831 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #776   +/-   ##
========================================
  Coverage    75.66%   75.66%           
========================================
  Files           97       97           
  Lines         9477     9477           
========================================
  Hits          7171     7171           
  Misses        1856     1856           
  Partials       450      450           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever
Copy link
Member

Please follow the pr template and complete the information.
Like this: #758

welkeyever
welkeyever previously approved these changes May 17, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@FGYFFFF
Copy link
Contributor

FGYFFFF commented May 17, 2023

@cqqqq777 The unit test seems to have some MIME content-type strings, would you like to help replace them together?

@cqqqq777
Copy link
Contributor Author

ok, I need some time.

@cqqqq777
Copy link
Contributor Author

may be some omissions, because there are too many unit test code

@cqqqq777
Copy link
Contributor Author

ok

@li-jin-gou
Copy link
Member

@cqqqq777 This is great and is what users need right now. But can we provide a document like fiber to help users know that we provide these constants. refer to https://docs.gofiber.io/api/constants .

@li-jin-gou li-jin-gou merged commit 2a0d46e into cloudwego:develop May 22, 2023
@cqqqq777
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants