clean up code for modeless dialogs #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creation of a modeless dialog that will not be displayed when EnableSaveRestore() is called. It is not dependent on the min/max state anymore, which adds flexibility. It adds one flag to the create method for derived dialogs.
Also was able to remove the SW_HIDE calls as they are non-functional when working. The two dialogs in question (download subs and fav organize) are set to be invisible on creation. The only reason fav dialog ever showed is the restorewindowstate call which displays it by default.
No need to create on the fly, either, removed that code for favorites.