Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show volume percentage on the volume bar, sliders lock to zero #2912

Merged
merged 11 commits into from
Jul 11, 2024
Merged

show volume percentage on the volume bar, sliders lock to zero #2912

merged 11 commits into from
Jul 11, 2024

Conversation

adipose
Copy link

@adipose adipose commented Jul 9, 2024

image

@adipose adipose mentioned this pull request Jul 10, 2024
Closed
@adipose adipose changed the title show volume percentage on the volume bar show volume percentage on the volume bar, sliders lock to zero Jul 10, 2024
@clsid2
Copy link
Owner

clsid2 commented Jul 11, 2024

Already tested it with high DPI and non-standard text scaling?

@clsid2 clsid2 merged commit 25fcc87 into clsid2:develop Jul 11, 2024
@clsid2
Copy link
Owner

clsid2 commented Jul 11, 2024

Now that % is shown in the bar, the volume tooltip is redundant.

Repository owner deleted a comment from BreakPoints Jul 11, 2024
Repository owner deleted a comment from BreakPoints Jul 11, 2024
@adipose
Copy link
Author

adipose commented Jul 11, 2024

Already tested it with high DPI and non-standard text scaling?

I tested high and low DPI. I'll check text scaling.

@adipose
Copy link
Author

adipose commented Jul 12, 2024

Text scaling is not relevant to the way it scales the font. It seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adipose @clsid2