Add an option to hide dev depencies in the graph. #19
Conversation
|
Thanks @Spy-Seth, the changes look good to me (on a high level) and your PR is very much appreciated 👍 Ideally, I'd like to merge this in, but on a more narrow level I'm a bit concerned with the relation to ticket #2. Before I take a decision, what's your opinion on this matter? So far, it's been my understanding that this should be fixed (upstream) in the underlying library and we should then update our dependencies. Either way, thanks for your submission! |
|
You're right, schmittjoh/composer-deps-analyzer need to be updated to correctly parse the devDependencies and allow us to safely work with. Meanwhile, the feature to show or not the dev-dependencies if still a must have feature. So I think this is not bad idea to merge this patch. And when the schmittjoh/composer-deps-analyzer dependency will be fix we could adapt the code with a proper implementation. |
|
Duh, sorry for the huge delay! I'm okay with getting this in here for now, instead of pushing this upstream. However, I'd prefer to have a reverse option Can you update this PR? |
|
Hi guys, how are you with this PR? 😃 |
|
@Pierstoval See my last comment :) I'd be happy to merge this once anybody finishes this 👍 |
|
Ho I've forgotten this one. I will try to update the PR this week. |
armandabric
changed the title
|
I just update the PR! |
| @@ -17,13 +17,14 @@ protected function configure() | |||
| ->setDescription('Show dependency graph image for given project directory') | |||
| ->addArgument('dir', InputArgument::OPTIONAL, 'Path to project directory to scan', '.') | |||
| ->addOption('format', null, InputOption::VALUE_REQUIRED, 'Image format (svg, png, jpeg)', 'svg') | |||
| /*->addOption('dev', null, InputOption::VALUE_NONE, 'If set, Whether require-dev dependencies should be shown') */; | |||
| ->addOption('no-dev', null, InputOption::VALUE_NONE, 'Hide dev dependencies.'); | |||
There was a problem hiding this comment.
Shouldn't no-dev be replaced by dev as in the Export command?
It would keep consistency between the two commands, therefore ensure better understandability
There was a problem hiding this comment.
Shouldn't dev be replaced by no-dev? :-) This way it's consistent with how composer works nowadays
There was a problem hiding this comment.
Indeed it's consistent with composer, but actually, I don't think we need the dev by default. It's an opinion, obviously 😉
There was a problem hiding this comment.
I would vote for not displaying dev deps by default
There was a problem hiding this comment.
Care to share some background, what's your motivation for hiding dev dependencies by default?
Here's my list why I think a --no-dev option makes more sense:
- It's in line with how composer works nowadays
- Without any options, you see all dependencies; optional arguments can be used to hide, so nothing ever goes unnoticed; this can be confusing, which options need to be passed to show everything?
- It's in line with how the other future options such as
--depthor--purgeare going to work - Changing the default display options should be considered a BC break
There was a problem hiding this comment.
i like it being consistent with composer. makes it a no-brainer.
|
Awesome! Please check the above inconsistency, otherwise LGTM 👍 |
|
I've updated the PR to fix the inconsistency. |
|
👍 great ! |
|
any update on this? |
|
Thanks for the update @Spy-Seth, LGTM 👍 I'll postpone this for now and am looking into getting this into the next release. |
| * You may optionally pass an `--format=[svg/svgz/png/jpeg/...]` option to set | ||
| the image type (defaults to `svg`). | ||
|
|
||
| * By default, all dependecies is show. If you only want to see the production dependencies you can add the `--no-dev` option. |
There was a problem hiding this comment.
How about "By default, graph-composer will show all dependencies (require and require-dev keywords). If you want to hide the require-dev dependencies, you can add the --no-dev option." ?
(see also above)
|
Thanks for your continuous effort @Spy-Seth, I've just check your changes and would love to get this in 👍 Can you rebase this on the current master? Also, do we have a sane way to add tests for this? |
|
I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. Please come back with more details if you think this is still relevant and we can reopen this 👍 See also #2 to continue the discussion. Thank you for your effort nonetheless, keep it up! 👍 |
No description provided.