-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options to filter production / development dependencies (supersedes #19) #35
Conversation
@clue Any updates on merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing this PR, very much appreciated 👍
At first sight, I like the new features and the implementation seems to be okay, too 👍
Unfortunately, this is currently very hard to review because it addresses multiple things at once and does not add any tests to verify the correct behavior.
I'd love to get these features in, so I'd like to ask you to break this up into multiple, smaller PRs to ease review and speed up getting this in Thanks!
@clue Thanks for your efforts. However, a couple of things:
|
No worries, we all know that feeling :-) Let's hope anybody (perhaps your future you) finds the time to pick this up again 👍
IMHO both options provides value on their own, but I understand YMMV 👍 I agree this is not exactly a killer here, but this would certainly ease reviewing this.
Yes and yes :-) The current implementation is rather trivial, but I'll look into filing some tests for this soon-ish 👍 The features you've added add some non-trivial complexity, so I'd argue it's about time to add some tests :-) |
I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. Please come back with more details if you think this is still relevant and we can reopen this 👍 See also #2 to continue the discussion. Thank you for your effort nonetheless, keep it up! 👍 |
I added the options
--no-dev
to exclude development dependencies from the graph,--dev-only
to visualize the root package and its dev dependencies only.This PR supersedes #19 which didn't work correctly for me. While it deleted the vertices from the root package to its immediate dev dependencies, the production dependencies of dev dependencies still kept them in the graph (resulting in multiple root nodes, e.g. the root package plus PHPUnit).
Please consider merging soon (before the package base changes again). Thanks!