Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added options to filter production / development dependencies (supersedes #19) #35
I added the options
This PR supersedes #19 which didn't work correctly for me. While it deleted the vertices from the root package to its immediate dev dependencies, the production dependencies of dev dependencies still kept them in the graph (resulting in multiple root nodes, e.g. the root package plus PHPUnit).
Please consider merging soon (before the package base changes again). Thanks!
Thanks for filing this PR, very much appreciated
At first sight, I like the new features and the implementation seems to be okay, too
Unfortunately, this is currently very hard to review because it addresses multiple things at once and does not add any tests to verify the correct behavior.
I'd love to get these features in, so I'd like to ask you to break this up into multiple, smaller PRs to ease review and speed up getting this in Thanks!
@clue Thanks for your efforts. However, a couple of things:
No worries, we all know that feeling :-) Let's hope anybody (perhaps your future you) finds the time to pick this up again
IMHO both options provides value on their own, but I understand YMMV
Yes and yes :-) The current implementation is rather trivial, but I'll look into filing some tests for this soon-ish