-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource synch process for delete event #592
Conversation
Hi @huiwq1990, DetailsInstructions for interacting with me using comments are available here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going ahead and fixing this, but there are a few things that still need to be discussed
Hi @huiwq1990 Are you guys using clusterpedia and would you mind if we communicate via wechat? |
ok, I will send my telephone via email. |
Signed-off-by: huiwq1990 <huiwq1990@163.com>
eef9a52
to
c4fcd8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But this also requires the memory storage layer to support PartialObjectMetadata, which of course may require other issues and pr to resolve
Also I think that not getting the resource version when deleting may have an effect on #593 as well.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When use binding-apiserver, ondelete should keep object's origin infomation. As memorystorage need object's metadata information.
Which issue(s) this PR fixes:
Fixes #569
Special notes for your reviewer:
Does this PR introduce a user-facing change?: