Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message queue to implement multi-cluster watch interface When using the default storage layer #593

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add message queue to implement multi-cluster watch interface When using the default storage layer #593

wants to merge 4 commits into from

Conversation

wuyingjun-lucky
Copy link
Member

@wuyingjun-lucky wuyingjun-lucky commented Nov 15, 2023 •
edited

What type of PR is this?
/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add message queue to implement multi-cluster watch interface

@clusterpedia-bot
Copy link

Hi @wuyingjun-lucky,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@wuyingjun-lucky wuyingjun-lucky marked this pull request as draft November 15, 2023 08:22
@wuyingjun-lucky
Copy link
Member Author

Fix #595

This was referenced Nov 17, 2023
Merged
Open
@wuyingjun-lucky wuyingjun-lucky marked this pull request as ready for review November 21, 2023 05:52
@wuyingjun-lucky
Copy link
Member Author

/cc @Iceber

@wuyingjun-lucky
Copy link
Member Author

Ready to be first round

@Iceber
Copy link
Member

Iceber commented Nov 29, 2023 •
edited

I noticed that this pr includes splitting the database tables

@calvin0327 is also moving forward with this recently, and we can discuss splitting tables further in the online meeting.
#601

@wuyingjun-lucky
Copy link
Member Author

wuyingjun-lucky commented Nov 30, 2023 •
edited

I noticed that this pr includes splitting the database tables

@calvin0327 is also moving forward with this recently, and we can discuss splitting tables further in the online meeting. #601

Do we need to remove the splitting tables or wait for the next meeting ？

@Iceber
Copy link
Member

Iceber commented Dec 1, 2023

I think the way the table is automatically split in this pr also makes a lot of sense, we can keep it in this pr for now and then discuss it as an example

wuyingjun-lucky and others added 4 commits December 27, 2023 08:47
@wuyingjun-lucky @OrangeBao
@xyz2277 @zhouhaoA1
implement watch.Interface
182b733 
Co-authored-by: baoyinghai <baoyinghai_yewu@cmss.chinamobile.com>
Co-authored-by: zhangyongxi <zhangyongxi_yewu@cmss.chinamobile.com>
Co-authored-by: zhouhao <zhouhao_yewu@cmss.chinamobile.com>
Signed-off-by: wuyingjun <wuyingjun_yewu@cmss.chinamobile.com>
@xyz2277 @wuyingjun-lucky
@OrangeBao @zhouhaoA1
create middleware interfaces for event sending and receiving
189fc9d 
Co-authored-by: wuyingjun <wuyingjun_yewu@cmss.chinamobile.com>
Co-authored-by: baoyinghai <baoyinghai_yewu@cmss.chinamobile.com>
Co-authored-by: zhouhao <zhouhao_yewu@cmss.chinamobile.com>
Signed-off-by: zhangyongxi <zhangyongxi_yewu@cmss.chinamobile.com>
@zhouhaoA1 @xyz2277
@OrangeBao @wuyingjun-lucky
rabbitmq implements of middleware interface
9f38fac 
Co-authored-by: zhangyongxi <zhangyongxi_yewu@cmss.chinamobile.com>
Co-authored-by: baoyinghai <baoyinghai_yewu@cmss.chinamobile.com>
Co-authored-by: wuyingjun <wuyingjun_yewu@cmss.chinamobile.com>
Signed-off-by: zhouhaoA1 <zhouhao_yewu@cmss.chinamobile.com>
@OrangeBao @xyz2277
@wuyingjun-lucky @zhouhaoA1
add a control switch and fix watch bug
bf2a5d5 
Co-authored-by: zhangyongxi <zhangyongxi_yewu@cmss.chinamobile.com>
Co-authored-by: wuyingjun <wuyingjun_yewu@cmss.chinamobile.com>
Co-authored-by: zhouhao <zhouhao_yewu@cmss.chinamobile.com>
Signed-off-by: baoyinghai <baoyinghai_yewu@cmss.chinamobile.com>
@wuyingjun-lucky
Copy link
Member Author

/cc @Iceber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iceber Iceber Awaiting requested review from Iceber

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wuyingjun-lucky @clusterpedia-bot @Iceber @xyz2277 @zhouhaoA1 @OrangeBao