-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for dividing table for internal storage #647
base: main
Are you sure you want to change the base?
Conversation
Hi @calvin0327, DetailsInstructions for interacting with me using comments are available here. |
I'll test the results later. |
b03565f
to
2fa7853
Compare
2fa7853
to
e2e9d7f
Compare
e2e9d7f
to
27a0499
Compare
@Iceber The pr basic feature have been completed, can we have reveiw first? |
27a0499
to
da628a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we do not support DivisionPolicyCustom in this pr?
- what if the divisionpolicy is "custom" or other value?
Signed-off-by: calvin <wen.chen@daocloud.io>
ffb80ad
to
36132b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if func CleanClusterResource is called when controller is not in dividing table mode. Calling generatetableFor may be incorrect.
2c74c42
to
f3a0dda
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to resolve table deletions is something we'll need to consider later.
d3eb132
to
ead917e
Compare
2559005
to
b6836a3
Compare
/retest |
8cef7a3
to
d34827e
Compare
here are test results: apiVersion: cluster.clusterpedia.io/v1alpha2
kind: PediaCluster
metadata:
name: cluster-example
spec:
apiserver: "https://10.30.43.43:6443"
caData:
tokenData:
certData:
keyData:
syncResources:
- group: apps
resources:
- deployments
- group: ""
resources:
- pods
[root@master01 ~]# kubectl get pediacluster
NAME READY VERSION APISERVER
cluster-example True v1.29.2 https://10.6.212.13:6443
[root@master01 ~]#
# DivisionPolicy is "None"
mysql> show tables;
+------------------------+
| Tables_in_clusterpedia |
+------------------------+
| resources |
+------------------------+
1 row in set (0.01 sec)
mysql>
[root@master01 ~]# kubectl --cluster clusterpedia get deploy -A
NAMESPACE CLUSTER NAME READY UP-TO-DATE AVAILABLE AGE
clusterpedia-system cluster-example clusterpedia-apiserver 1/1 1 1 3h17m
clusterpedia-system cluster-example clusterpedia-clustersynchro-manager 1/1 1 1 3h17m
clusterpedia-system cluster-example clusterpedia-controller-manager 1/1 1 1 3h17m
kube-system cluster-example cilium-operator 2/2 2 2 77d
kube-system cluster-example coredns 2/2 2 2 84d
kubeflow cluster-example training-operator 1/1 1 1 24d
volcano-system cluster-example volcano-admission 1/1 1 1 30d
volcano-system cluster-example volcano-controllers 1/1 1 1 30d
volcano-system cluster-example volcano-scheduler 1/1 1 1 30d
[root@master01 ~]# kubectl delete pediacluster cluster-example
pediacluster.cluster.clusterpedia.io "cluster-example" deleted
[root@master01 ~]# kubectl --cluster clusterpedia get deploy -A
Error from server (NotFound): Unable to list "apps/v1, Resource=deployments": the server could not find the requested resource (get deployments.apps)
# DivisionPolicy is "GVR"
mysql> show tables;
+------------------------+
| Tables_in_clusterpedia |
+------------------------+
| apps_v1_deployments |
| v1_pods |
+------------------------+
2 rows in set (0.00 sec)
mysql>
[root@master01 clusterpedia]# kubectl --cluster clusterpedia get deploy -A
NAMESPACE CLUSTER NAME READY UP-TO-DATE AVAILABLE AGE
clusterpedia-system cluster-example clusterpedia-apiserver 1/1 1 1 3h57m
clusterpedia-system cluster-example clusterpedia-clustersynchro-manager 1/1 1 1 3h57m
clusterpedia-system cluster-example clusterpedia-controller-manager 1/1 1 1 3h57m
kube-system cluster-example cilium-operator 2/2 2 2 77d
kube-system cluster-example coredns 2/2 2 2 84d
kubeflow cluster-example training-operator 1/1 1 1 24d
volcano-system cluster-example volcano-admission 1/1 1 1 30d
volcano-system cluster-example volcano-controllers 1/1 1 1 30d
volcano-system cluster-example volcano-scheduler 1/1 1 1 30d
[root@master01 clusterpedia]# kubectl delete pediacluster cluster-example
pediacluster.cluster.clusterpedia.io "cluster-example" deleted
[root@master01 clusterpedia]# kubectl --cluster clusterpedia get deploy -A
Error from server (NotFound): Unable to list "apps/v1, Resource=deployments": the server could not find the requested resource (get deployments.apps) |
d865443
to
599a403
Compare
Signed-off-by: calvin <wen.chen@daocloud.io>
599a403
to
723c0d2
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #601
Special notes for your reviewer:
Does this PR introduce a user-facing change?: