Skip to content

Conversation

DuBistKomisch
Copy link
Contributor

Addresses #30.

clux added a commit that referenced this pull request Sep 4, 2015
Treat rtpmap rate parameter as optional
@clux clux merged commit 60ebf29 into clux:master Sep 4, 2015
@clux
Copy link
Owner

clux commented Sep 4, 2015

Nicely done. Parsing tests look good. Thanks for adding an extra sdp for this.
The writer string is untested, but can add it to the compose test to lock that down as well.

Regex is getting a bit unweildy, but guess that's what we get for treating two things as optional.
I'll publish a version on saturday, for now rely on the github version.

Thanks a lot.

@DuBistKomisch
Copy link
Contributor Author

Well you know what they say about Regexes...

Thanks for merging and publishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants