-
Notifications
You must be signed in to change notification settings - Fork 0
Update to use normalized URIs #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update CMake configuration files to require the CMUTIL component from the CMLIB package in addition to STORAGE. The storage URI assignment is now performed using the CMUTIL_NORMALIZE_GIT_URI macro/function, which normalizes the URI instead of assigning it directly as a string. Changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Depends on cmakelib/cmakelib-component-cmutil#3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
example/CMLibStorage.cmake
(1 hunks)example/CMakeLists.txt
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: test_windows (.)
- GitHub Check: test_linux (test_debian:bookworm, .)
- GitHub Check: test_macos (.)
🔇 Additional comments (2)
example/CMakeLists.txt (1)
7-7
: LGTM! Proper component addition for URI normalization support.The addition of the CMUTIL component to the FIND_PACKAGE call is necessary and correctly implemented to support the URI normalization functionality.
example/CMLibStorage.cmake (1)
7-10
: LGTM! Proper implementation of URI normalization.The CMUTIL_NORMALIZE_GIT_URI macro usage is correctly implemented with proper parameter syntax and aligns with the PR objective of using normalized URIs instead of direct string assignment.
Summary by CodeRabbit