Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial section: Parsing a subset of a GCTX file #10

Closed
antonkratz opened this issue Jan 4, 2018 · 1 comment
Closed

tutorial section: Parsing a subset of a GCTX file #10

antonkratz opened this issue Jan 4, 2018 · 1 comment

Comments

@antonkratz
Copy link

antonkratz commented Jan 4, 2018

In the tutorial, section "Parsing a subset of a GCTX file":
sig_ids <- col_meta$sig_id[idx]
This will not work because two lines earlier the metadata file has been loaded with row.names=1. So, there is no column sig_id anymore! Therefore sig_ids will be NULL (empty).

One solution would be to replace
sig_ids <- col_meta$sig_id[idx]
with
sig_ids <- row.names(col_meta[idx,]).

sig_ids is now a list of rownames.

tnat1031 added a commit that referenced this issue Jan 5, 2018
@tnat1031
Copy link
Contributor

tnat1031 commented Jan 5, 2018

thanks @antonkratz ! just pushed a fix

@tnat1031 tnat1031 closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants