Dealing with changes in rhdf5 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of
rhdf5::H5close()has changed as a result of updating the underlying HDF5 library. InvokingH5close()now not only closes any open object handles, but also shuts down the C-library so nothing works after, rending it fairly useless. The functionality to close any open objects can now be achieved withh5closeAll().The changes in this pull request should make the affected cmapR functions compatible with both the 'old' version of rhdf5 e.g. versions < 2.23.0, and also the changed behaviour in rhdf5 >= 2.23.0.