Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moment of inertia function #40

Merged
merged 2 commits into from
May 5, 2022

Conversation

chrisjonesBSU
Copy link
Member

@chrisjonesBSU chrisjonesBSU commented May 2, 2022

This is useful for rigid body stuff, so I figured we could add it to our "tool box".

I still need to make a unit test for it. Just making the PR now to get another set of eyes on it.

Also, credit to Jenny for writing the function, I just copied it over to this repo.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #40 (2952c5f) into master (08c1605) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   99.09%   99.11%   +0.02%     
==========================================
  Files           7        7              
  Lines         331      340       +9     
==========================================
+ Hits          328      337       +9     
  Misses          3        3              
Impacted Files Coverage Δ
cmeutils/geometry.py 100.00% <100.00%> (ø)

Copy link
Member

@jennyfothergill jennyfothergill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Edit: after this is merged, let's bump the version so that any packages that depend on this function (like polyelipsoid) can specify after this version.

@chrisjonesBSU chrisjonesBSU merged commit 9896781 into cmelab:master May 5, 2022
@chrisjonesBSU chrisjonesBSU deleted the add/moit branch May 5, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants