Fix normalizaiton of bond and angle distributions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjonesBSU
requested review from
RainierBarrett,
jennyfothergill and
gwenwhite
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 7 7
Lines 340 340
=======================================
Hits 337 337
Misses 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the normalization parameter in both bond and angle distribution functions wasn't doing anything. The actual normalization is performed in
plotting.get_histogram, which both of these functions use, but the normalization parameter was never passed along. This PR fixes that, and adds 2 unit tests that call the bond and angle distribution functions (the normalization was already tested directly by callingget_histogram)