-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2D and 3D grid positions #48
Conversation
Thanks for adding these :) A couple things:
|
Looks like the rigid body related tests are failing. We should probably pin hoomd < 4.0. Per the hoomd 4 release notes:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 99.07% 95.54% -3.53%
==========================================
Files 7 7
Lines 431 449 +18
==========================================
+ Hits 427 429 +2
- Misses 4 20 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding this @marjanAlbouye
This PR adds the following functions to the geometry file:
radial_grid_positions
: returns a radial grid of 2D positions between two radii. Number of circles between the two radii, number of points in each circle and the coverage angle of each circle can be customized.spherical_grid_positions
: returns a spherical grid of 3D positions between two radii and an angle along z axis. Number of circles between the two radii, number of points in each circle and the coverage angle of each circle can be customized.These functions can be useful when a fixed set of positions needs to be swipped in a simulation.