Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker compose for dev and prod env #1228

Closed
wants to merge 2 commits into from

Conversation

peterxcli
Copy link

I wonder why this repo has no docker-compose for production(to run the admin-webServer just after you up a docker-compose) is there any issue cause there is no container for deployment config file

So I have added two docker compose file for development and production respectively.
I'm seeking your opinion for this commit, thanks

@wil93
Copy link
Member

wil93 commented Mar 27, 2023

Hello, and sorry for the delay. Thanks for the PR 😄

The docker-compose.test.yml file was added in #1221, where I mentioned that it would make sense to make a development version of it, but maybe not a production version just yet, since each situation can be slightly different I guess (contest admins can write a yml file themselves, and reuse just the Dockerfile).

As for having separate Dockerfiles, I think it would be best to try as much as we can to always keep only one image that supports all use cases (testing, development, production).

In summary, I would not add a prod yml file yet, and for a dev yml file we should understand what we need for local development. For example storing the DB in /tmp is probably not a good idea for local development, it would be better to store it in a temporary folder within the repo so that the data is preserved after reboot.

@peterxcli peterxcli closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants