-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase2 PV sorting is not using HGCAL inputs (only the barrel and HF contribute to ak4CaloJetsForTrk) will be needed for jetCore as well #31843
Comments
A new Issue was created by @slava77 Slava Krutelyov. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction,upgrade |
Just for record: |
@mariadalfonso @gouskos @werdmann |
the sorting is currently used in |
@hqucms @missirol @pallabidas : Any insight on this? |
To my knowledge, we don't. Indeed, I think this suboptimal approach (i.e. CaloJets-without-HGCal-inputs used for PV sorting) was used in the HLT TDR, for lack of an alternative or a dedicated study. The only PV-sorting studies I remember for Phase-2 were done by @AdrianoDee, so he might have some more (quantitative) insight. |
Mhm, OK, I thought for the PV sorting we were using only the track information ? |
This is the case, track-only sorting, for Pixel Vertices (and then for the trimming related selection). For offline-like PVs we still use |
Hi @fwyzard , for sorting of PVs from 'full' tracks, I think for HLT Phase-2 we are currently doing the same as Offline, and that uses a more sophisticated method. |
OK, this is the part I had in mind (the part that we run before the full tracking). |
Indeed... since it's not clear if there will be "calo" jets from HGCAL, what prevents using the full particle flow jets (barrel PF + TICL) instead ? Apart form "somebody has to do it", of course. |
For HLT it would mean we have to run TICL (basically) anytime we run tracking just for the PV sorting. This is the only issue (?) I see. Apart from the "somebody has to do it" one. |
OK, then let me ask... what is the PV sorting used for ? |
Maybe, a simpler approach for TDR studies would be to try and disable the jet-dependent part of PV sorting, to understand what its quantitative impact is.
One thing is PU mitigation. For example, PUPPI needs to know what the "leading PV" (the first, after sorting) is. |
Right - and in this case, we have already run TICL and PF. |
Yes; at least for jets and MET in the Phase-2 HLT config, TICL already runs on all events for which we run full tracking, so I guess one could (in principle) use PFJets instead of the CaloJets for the sorting, in this particular case. Of course, this assumes that we can run PF before PV sorting (in other words, that PF does not rely on PV sorting), which I guess it's the case, but I don't know for sure. |
@fwyzard some background here: Currently "the" PV is already used in the construction of the PF candidates (mainly for assigning the direction of neutrals), so that part has to run before PF. It's been discussed to have an "additional" pv sorting step making use of higher level information, to be used for Puppi, etc, also for Run 3, but not implemented yet. The CaloJets are used currently to help recover displaced tracks from B decays, but performing some additional checks with respect to the jet axis. |
in addition to what @bendavid described above in #31843 (comment) in the earlier steps |
One note unrelated to PV sorting: it seems that the |
type tracking |
@cms-sw/upgrade-l2 is this still relevant? |
Yes, because as far as I know no PV sorter has been implemented to take into account HGCal and it is still relying on |
investigations of cluster merging in jet cores have also shown that jet core splitting will be beneficial in phase-2 tracking |
cms-bot internal usage |
@rovere @felicepantaleo |
Yes we can run AK4 directly on layer clusters and produce jets, for example. The plugin is in release. It just needs manpower to set it up. |
this is a follow up to #31743
#31743 (comment)
CaloJets (
ak4CaloJetsForTrk
made out ofcaloTowerForTrk
) are used in PV sorting and none of the HGCAL inputs are used in the phase-2 setup.The jets are used to assign (otherwise unattached to a vertex due to displacement) tracks to a vertex if there is some alignment of the track with a calojet axis.
It's still probably making it for just a suboptimal performance rather than a bug for vertexing in phase2.
Still, some assessment and possible resolution is needed.
It could be that the calojets should not be used this way at all in phase-2 high-pileup.
@mtosi @vmariani @hatakeyamak @bendavid
[added May 15, 2024]
investigations of cluster merging in jet cores have also shown that jet core splitting will be beneficial in phase-2 tracking
https://indico.cern.ch/event/1396796/#30-jetcore-and-cluster-splitti
some pre-tracking jet activity measure would be needed in the HGCAL direction
@langufo @emiglior @VourMa @kskovpen @mmasciov
The text was updated successfully, but these errors were encountered: