Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all nanoV10 workflows #40475

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Jan 11, 2023

PR description:

Remove the left-over nanoAOD v10-frozen workflows forgotten in #40321, fix issue reported in #40321 (comment)

@swertz
Copy link
Contributor Author

swertz commented Jan 11, 2023

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40475/33651

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swertz (Sébastien Wertz) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor Author

swertz commented Jan 11, 2023

please test

@smuzaffar
Copy link
Contributor

test parameters:

  • workflow = 140.01,140.03

@smuzaffar
Copy link
Contributor

please test
lets run the tests for failing workflows too

@perrotta
Copy link
Contributor

type bugfix

@perrotta
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70b29d/29910/summary.html
COMMIT: 298ad8e
CMSSW: CMSSW_13_0_X_2023-01-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40475/29910/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.01 step 3
140.03 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 20410 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555513
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 217 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Previously failing run3 nanoAOD workflows can finish without errors with this fix
  • @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 let me bypass your signature to have the IB clean in master, but please feel free to comment or propose different solutlons even after this PR gets merged

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c2c3b50 into cms-sw:master Jan 11, 2023
@srimanob
Copy link
Contributor

Hi @perrotta

As a question in #40321 (comment), should we consider to add 2022 data workflow to runTheMatrix? So it can be tested at every PR test, and spot any issues before we reprocess it.
We currently have only 2021 wf, which I think they will be less use, for physics analysis, compared with 2022.

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L77-L79

@perrotta
Copy link
Contributor

Hi @perrotta

As a question in #40321 (comment), should we consider to add 2022 data workflow to runTheMatrix? So it can be tested at every PR test, and spot any issues before we reprocess it. We currently have only 2021 wf, which I think they will be less use, for physics analysis, compared with 2022.

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L77-L79

I fully agree.
We can either add the 2022 workflows, or just replace the 2021 ones with them, which is probably better if we want to keep the short matrix short

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants