-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce BeamSpotOnlineProducer
for Phase-2 HLT menu
#41193
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41193/34886
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test workflow 20834.76 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0346f4/31613/summary.html Comparison SummarySummary:
|
+alca
|
@beaucero @SohamBhattacharya , please have a look and let us know if you agree with this change to the Phase-2 HLT menu (cc: @fwyzard , as author of #41047). |
HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPOnlineBeamSpotProducer_cfi.py
Outdated
Show resolved
Hide resolved
HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPOnlineBeamSpotProducer_cfi.py
Outdated
Show resolved
Hide resolved
we use the same setup that is proposed here. |
Hi, this looks fine as far as Phase-2 HLT is concerned. Please go ahead. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0346f4/31679/summary.html Comparison SummarySummary:
|
HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltOnlineBeamSpotESProducer_cfi.py
Show resolved
Hide resolved
+hlt |
+alca
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR proposes a somewhat alternative approach to deliver the online Beam Spot to the HLT menu in Phase-2 as the one introduced at #41047.
The goal is to re-align the Phase-2 HLT configuration to be the same as in Run3 (i.e. use
BeamSpotOnlineProducer
instead ofBeamSpotProducer
) this is achieved by means of:hltOnlineBeamSpotESProducer
(ESProducer
for the arbitration) to the HLT menu itself;useTransientRecord = True
in theonlineBeamSpot
configuration (in this way one do not need to use scalers input any longer);As with the proposed configuration the
BeamSpotOnlineProducer
falls back into producing the in the event the content of the DB (BeamSpotObjectsRcd
) this should not introduce any change in the HLT results.One of the main objections to use
BeamSpotOnlineProducer
for the phase-2 setup was about the fact that it needs to consumeBeamSpotOnlineCollection
from the SCAL FED (which doesn't exist anymore in >= Run3). I therefore profit of this PR to changeBeamSpotOnlineProducer
in order to not consume it unlessuseTransientRecord
is set toFalse
. This and declaring this parameter as optional in thefillDescription
method ofBeamSpotOnlineProducer
allows to avoid declaringhltScalersRawToDigi
as input collection.PR validation:
Successfully run:
runTheMatrix.py -l 20834.76
addOnTests.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A