-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0.X] Produce a fake BeamSpot
object in BeamSpotOnlineProducer
when using transient record logic and OnlineBeamSpotESProducer
returned a fake
#41674
Conversation
…by letting the BeamSpotOnlineProducer deal automatically with the arbitrated one
…FromOfflineConverter
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X. It involves the following packages:
@clacaputo, @cmsbuild, @saumyaphor4252, @francescobrivio, @mandrenguyen, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e49873/32634/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #41597 (partial)
PR description:
While working on #41193, I have noticed that despite
OnlineBeamSpotESProducer
has a refined logic in order to put into the event setup a fake BeamSpot when certain conditions are not met:cmssw/RecoVertex/BeamSpotProducer/plugins/OnlineBeamSpotESProducer.cc
Lines 168 to 174 in a52f2d1
the current
BeamSpotOnlineProducer
logic, ifuseTransientRecord_
is true and theOnlineBeamSpotESProducer
returned a fake beamspot, just falls back to DB (reading the content ofBeamSpotObjectsRcd
, populated by the PCL in realtime workflows) - which I have understood from the Beam Spot experts is not the right / expected behaviour.cmssw/RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc
Lines 104 to 111 in a52f2d1
In this PR (in commit 5a3afff) I change the current behaviour, such that instead now it will indeed produce a fake BS for consumption online (as it was originally devised).
In the master branch, I have found convenient to create a new plugin
BeamSpotOnlineFromOfflineConverter
that taking aBeamSpotObject
in input creates an sqlite file in output containing a payload of the typeBeamSpotOnlineObjects
. This has been added in commit 0b2e105, while commits 6f1912e and 5c011c8 add a utility accessor to theBeamSpotOnlineObjects
condtion format to be able to readily copy from aBeamSpotObjects
payload (friend class) all the common parameters. Finally commit 991186b adds this converter to the battery of unit tests of theCondTools/BeamSpot
package.N.B.
I have NOT backported commits d5eedb8 and 63e821e in this PR as they are not needed. Indeed in 13.0.X the phase-2 HLT menu uses the offline BeamSpot directly, without using the fallback mechanism, see:
cmssw/HLTrigger/Configuration/python/HLT_75e33/modules/offlineBeamSpot_cfi.py
Lines 1 to 3 in 3dc3c13
(the move was done in #41047 which was not backported)
PR validation:
cmssw
complies. Passes back unit tests.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport of #41597, to be backported down to 13.0.X for 2023 data-taking purposes.