Run3-hcx354 Modify the DetId fo ZDC to accommodate the changes that happened during Run3 and some provision for the future

[bsunanda]

PR description:

Modify the DetId fo ZDC to accommodate the changes that happened during Run3 and some provision for the future

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be back ported to 13_3_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43200/37521

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43200/37521/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43200/37521/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43200/37522

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• DataFormats/HcalDetId (simulation)
• Geometry/ForwardGeometry (geometry)

@makortel, @bsunanda, @civanch, @cmsbuild, @mdhildreth, @Dr15Jones can you please review it and eventually sign? Thanks.
@rovere, @missirol, @abdoulline, @mariadalfonso, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[abdoulline]

Unit test broken as expected, as tested without #43220 .

[perrotta]

please test with #43220

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-675a4b/35712/summary.html
COMMIT: 1c8a060
CMSSW: CMSSW_14_0_X_2023-11-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43200/35712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 140 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 1791
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361197
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

#43220 is already merged.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

@perrotta @rappoccio @antoniovilela Please approve this

[antoniovilela]

@perrotta @rappoccio @antoniovilela Please approve this

Hi Sunanda,
It is better to ping us with @cms-sw/orp-l2.

[antoniovilela]

+1