HcalZDCDetId fix for Run3

[abdoulline]

PR description:

Fix of a bug in Run3 update of the HcalZDCDetId #43200
which prevented a proper serialization of the conditions for newly added Run3-specific ZDC readouts (RPD)

PR validation:

(1) new Run3 ZDC conditions can now be parsed and dumped, once ZDC indexing parameter is set for Run3 The latter will be rearranged in the subsequent PR(s) by @bsunanda together with some ZDC Geometry initialization updates.
(2) runTheMatrix.py -l limited

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45033/40325

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline for master.

It involves the following packages:

• DataFormats/HcalDetId (simulation)

@mdhildreth, @civanch, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @mariadalfonso, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@abdoulline for my education is this going to help solving #44866 (and #43582) ?

[abdoulline]

@abdoulline for my education is this going to help solving #44866 (and #43582) ?

@mmusich not "per se", this is a(n intermediate but indispensable) step towards the goal.
As I've mentioned in the description, we need Sunanda's intervention into ZDC Geometry initialization.

[mmusich]

not "per se", this is a(n intermediate but indispensable) step towards the goal.

Right, this is what I meant by "help".

[mmusich]

@cmsbuild, please test

[mmusich]

type hcal, bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a02c2f/39513/summary.html
COMMIT: 2c86f71
CMSSW: CMSSW_14_1_X_2024-05-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45033/39513/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1