-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF emulator support for 2024 primitive converison LUTs #45105
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45105/40433
|
A new Pull Request was created by @eyigitba for master. It involves the following packages:
@epalencia, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test with cms-data/L1Trigger-L1TMuon#28 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acae34/39632/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
cms-data/L1Trigger-L1TMuon#28 now merged. |
+1 |
PR description:
This PR adds options to use the new primitive conversion LUTs in the EMTF emulator. The LUTs were deployed at P5 on May 28th, but they are not used in the emulator yet.
This PR needs the LUTs in cms-data/L1Trigger-L1TMuon#28 to work.
We see improvement in EMTF performance at P5 with these new LUTs, so changes to muon efficiencies etc are expected when testing the re-emulation workflows from recent runs.
This PR will be backported to 14_0_X.
PR validation:
Validated by comparing unpacked and re-emulated collections from recent runs. Emulator picks the correct LUTs based on firmware version. Results are as expected.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A