V624 issue 10131 #167
Closed
V624 issue 10131 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-24-00-patches/4b08829. @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c9a64/23542/summary.html Comparison SummarySummary:
|
This is done also for multimap.
When encountering a data member of a class that is a enum or if it is use in a map or multimap, record the enum in the rootpcm.
This was a fatal typo in 9678405 pair: properly update StreamerInfo.
We already had TListOfEnumsWithLock but TListOfEnums::FindObject is used by rootcling
In the 'root_serialization' use case, we ended in TBufferFile::WriteClassBuffer with no StreamerInfo created yet for the TClass for `std::vector<float>` and thus go into the branch that creates the StreamerInfo ... However, at least in that case, the call to `BuildRealData` induced the creation of the StreamerInfo but the code in `TBufferFile::WriteClassBuffer` did not notice and thus create a second one and tried to register it in the same slot. (The actual negative side effect was only an error message and a memory leak).
This happened in a user case where the container (map) for a pair of an enum, which had not dictionary and something else that did have a dictionary.
This was happening when, inadvertently, StreamerInfo were created multiple times and then immeditately deleted (for map<enumtype_without_dict, somethinelse>)
|
Pull request #167 was updated. |
|
Pull request #167 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.