Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fountain pen #3727

Merged
merged 14 commits into from
Jul 4, 2023
Merged

Fountain pen #3727

merged 14 commits into from
Jul 4, 2023

Conversation

Hopekz
Copy link
Contributor

@Hopekz Hopekz commented Jun 26, 2023

Adds a Luxurious fountain pen to the game. Currently spawns on the right ear of high ranking command staff as well as the corporate liaison.

What makes this pen special besides looking fancy?
dreamseeker_ayCdkAmUBg
dreamseeker_bdX1Mp6lOy

New colors to write with included with this amazon pen!! I think this will enable deeper RP of having something be signed with an X color meaning it was signed by command staff (or someone posing as command).

To-do that I haven't done yet because I haven't found the code and if I don't do this before it is merged I'll just make a new PR for it so don't let it block a merge:

  • Add a mob sprite to add these on to people's helmets so that a marine can look fancy and decorated by receiving a pen. Sprites exist for this just haven't implemented it yet.

🆑 Hopek, Gul Dreggrod
add: Adds a Luxurious fountain pen to the game. Currently spawns on the right ear of high ranking command staff. Sprited by Gul Dreggrod.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -19. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jun 26, 2023
code/game/objects/items/tools/misc_tools.dm Outdated Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Outdated Show resolved Hide resolved
@fira
Copy link
Member

fira commented Jun 26, 2023

Why not just seed them on map? It's a cool feature but having them as forced ear spawn is a bit goofy

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 26, 2023

Implemented this:
image

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 26, 2023

to do:
Make this available for points

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 26, 2023

Why not just seed them on map?

image

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 26, 2023

image

Implemented for 3 points (no idea if it should be more but that's what it is right now)

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 26, 2023

Forgot to post an image of orange:
image

code/game/objects/items/tools/misc_tools.dm Outdated Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Outdated Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Outdated Show resolved Hide resolved
code/game/objects/items/tools/misc_tools.dm Show resolved Hide resolved
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the onmobs are fine but the object needs some tweaking
get rid of the true black shade between the pen head and the body, your second darkest value does the same job and a full black should generally be avoided.
image

for the highlights move the grey values around on the body to follow the line established by the brighter white pixels (which i think should also be changed to a slightly softer yellowy color)
image

something like what's on the right is ultimately what i'm looking for
image

@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 2, 2023

something like what's on the right is ultimately what i'm looking for
image

Can't you just give me the sprite modification that you created for your example?

@sleepynecrons
Copy link
Contributor

something like what's on the right is ultimately what i'm looking for
image

Can't you just give me the sprite modification that you created for your example?

no you or the original spriter should make the modifications (also i didn't save the file i drew it on :^) )

@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 3, 2023

no you or the original spriter should make the modifications (also i didn't save the file i drew it on :^) )

Okay I went ahead and worked with Gul to get it updated.
Personally I don't see the difference between the two; it is such a small difference that probably won't make an impact. I guess the new one probably has less black per your directions.

Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 approved

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Jul 3, 2023
@harryob harryob added this pull request to the merge queue Jul 4, 2023
Merged via the queue into cmss13-devs:master with commit b5507f5 Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Your Fix/Feature pull request is currently below zero (-21). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 4, 2023
cm13-github added a commit that referenced this pull request Jul 4, 2023
@Hopekz
Copy link
Contributor Author

Hopekz commented Jul 4, 2023

Your Fix/Feature pull request is currently below zero (-21). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

🖕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants