Skip to content

Add nation and HHS to CHC #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 10, 2020
Merged

Add nation and HHS to CHC #613

merged 8 commits into from
Dec 10, 2020

Conversation

chinandrew
Copy link
Contributor

Description

Merge after #610

Add HHS and nation to Change.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Update conditional statements to map to nation and hhs
  • Update tests to run the hhs and nation cases

Fixes

  • n/a

@chinandrew chinandrew marked this pull request as draft December 9, 2020 08:45
Base automatically changed from add-hhs-to-utils to main December 9, 2020 19:57
rumackaaron
rumackaaron reviewed Dec 9, 2020
View reviewed changes
@rumackaaron
Copy link
Contributor

We'd also have to change params.json in ansible/templates/changehc-params-prod.json.j2

chinandrew and others added 2 commits December 9, 2020 13:01
@chinandrew chinandrew marked this pull request as ready for review December 9, 2020 21:02
@chinandrew
Copy link
Contributor Author

We'd also have to change params.json in ansible/templates/changehc-params-prod.json.j2

Ah thanks for pointing this out, I've added that change

@rumackaaron rumackaaron self-requested a review December 9, 2020 21:08
@krivard krivard merged commit 63f2697 into main Dec 10, 2020
@krivard krivard deleted the change-hhs-nation branch December 10, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumackaaron rumackaaron rumackaaron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chinandrew @rumackaaron @krivard