Skip to content

Conversation

chinandrew
Copy link
Contributor

Description

Merge after #610

Add HHS and nation to safegraph. There's some test code duplication that can be removed that I didn't bother with in this PR.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Update conditional statements to map to nation and hhs
  • Update tests to run the hhs and nation cases

Fixes

  • n/a

@chinandrew chinandrew marked this pull request as draft December 9, 2020 08:59
Base automatically changed from add-hhs-to-utils to main December 9, 2020 19:57
@chinandrew chinandrew marked this pull request as ready for review December 9, 2020 21:04
@chinandrew chinandrew requested review from a team and jingjtang and removed request for a team December 9, 2020 21:14
We import census block group-level raw mobility indicators from Safegraph,
calculate functions of the raw data, and then aggregate the data to the
county and state levels. MSA and HRR not yet implemented.
county and state levels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better change to "aggregate the data to the county, MSA, HRR, state, HHS and national levels."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

@jingjtang
Copy link
Contributor

jingjtang commented Dec 10, 2020

All tests pass.
Linting looks good.

Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 1062cc4 into main Dec 16, 2020
@krivard krivard deleted the safegraph-hhs-nation branch December 16, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants