Skip to content

feat: remove missing workaround #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2021
Merged

feat: remove missing workaround #603

merged 1 commit into from
Jun 20, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jun 18, 2021

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

removes the workaround for the nan/missing columns

@sgratzl sgratzl self-assigned this Jun 18, 2021
@sgratzl sgratzl requested a review from krivard June 18, 2021 15:19
@sgratzl sgratzl added the chore label Jun 18, 2021
krivard
krivard approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 72cafcd into dev Jun 20, 2021
@sgratzl sgratzl deleted the sgratzl/remove_workaround branch June 20, 2021 09:58
@krivard krivard mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @krivard