Skip to content

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

  • move style, lint, document, preview-docs all in pr-commands.yaml
  • all are now triggered with PR comments, instead of auto-running
  • update PR template to remind user to run these commands

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

* style, lint, document, preview-docs all in pr-commands and can now be triggered with PR comments
* update PR template to remind user to run these commands
@dshemetov dshemetov requested a review from brookslogan April 1, 2025 01:06
@dsweber2
Copy link
Contributor

dsweber2 commented Apr 1, 2025

Do we have these set up as optional in e.g. epipredict? Or is this a first

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 1, 2025

Yes cmu-delphi/epipredict#453

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it's going to remove a lot of annoyance! See potential todo in inline comments.

@dshemetov dshemetov merged commit 7180b93 into dev Apr 3, 2025
3 checks passed
@dshemetov dshemetov deleted the ds/pr-commands branch April 3, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants