Skip to content

Fix dashboard docker dependencies: markdown, sf #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2021
Merged

Fix dashboard docker dependencies: markdown, sf #172

merged 2 commits into from
Sep 23, 2021

Conversation

nmdefries
Copy link
Collaborator

Description

Add/fix installation of markdown and sf R packages for dashboard docker container.

Changes

  • Install markdown package.
  • Install Linux packages so that sf is successfully installed.
  • Formatting improvements
  • Ask install2.r to quit if any packages are not successfully installed, to prevent silent failures.

Fixes

  • App started complaining that markdown wasn't installed
  • Bonus: sf has never been installed successfully

korlaxxalrok
korlaxxalrok approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 (sorry for the delay!)

@nmdefries nmdefries merged commit e07dd62 into dev Sep 23, 2021
@nmdefries nmdefries deleted the fix-docker-dash-dependencies branch September 23, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlaxxalrok korlaxxalrok korlaxxalrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @korlaxxalrok