Skip to content

Make sure score explanations appear at the right time #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented Oct 13, 2021

Patch template refactor. Swap in shinyjs::showElement for shinyjs::show and shinyjs::hideElement for shinyjs::hide. These are meant to be synonyms, but the short versions aren't recognized in the refactor, causing score explanations and notes to not show up when expected.

Closes #191.

@nmdefries nmdefries requested review from sgratzl and krivard October 14, 2021 00:03
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

👻

@nmdefries nmdefries merged commit 6ab76a9 into add-template-refactor-back-plus-patches Oct 19, 2021
@nmdefries nmdefries deleted the fix-missing-messages branch October 19, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants