-
Notifications
You must be signed in to change notification settings - Fork 3
Support showing predictions for future dates in the dashboard #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
reviewed
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic questions
…rlier than others
krivard
reviewed
Mar 2, 2022
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
krivard
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to request and see predictions for future dates made by selected forecasters.
Changes
Makefile
:pull_data
target to pull new saved datetime.app/R/data.R
: data loader to get cached datetime in addition to scores.app.ui.R
: enable "show forecasts" button for all as-of dates by default.app/R/data_manipulation.R
:filterOverAllLocations()
to take newfilterDate
arg.filterDate
is used to remove predictions that are in the past (relative to when the data was generated) but don't have scores despite having truth data available. This lets us keep predictions that are in the future and don't have scores (because truth data wasn't available).app/server.R
:plotly
package seems to have changed handling ofggplot
legends so that we see duplicate entries for a given forecaster.filterScoreDf()
logic to match `filterOverAllLocations()filterForecastData()
to work with (past as-of dates) or without (most recent as-of date) as-of data.Fixes
Closes #203