Skip to content

Cleanup after 7.1.0 release #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Cleanup after 7.1.0 release #292

merged 2 commits into from
Jun 26, 2023

Conversation

nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented Jun 23, 2023

Keep version on dev up to date with main.

@nmdefries nmdefries requested a review from dsweber2 June 23, 2023 20:12
@nmdefries
Copy link
Collaborator Author

nmdefries commented Jun 23, 2023

Release Main failure is known, occuring after merge of #285. Seems to be related to the recent deprecation of Node12. I'll need to fix that on dev and do another merge into main.

@nmdefries nmdefries requested a review from krivard June 23, 2023 20:14
@dsweber2
Copy link
Collaborator

do we have a way to tell the robots to run the CI again, after the other pull request was merged?

@nmdefries
Copy link
Collaborator Author

nmdefries commented Jun 23, 2023

So #293 was added to dev. We need to merge dev into main before trying to release main again using the automatic method (since otherwise it won't have the updated workflow file and will fail in the same way).

I can run the Release Main workflow manually off of the dev branch, but it's not clear to me that that would be able to release main (which has it's own version of that workflow file) without error. I never considered doing this 🤔

Edit: Looking at this idea in more detail, it wouldn't work with the current workflow file. We need to use the workflow file on dev but process the main branch in the workflow (to get up to date version values). However, the workflow via actions/checkout always processes the branch the workflow was run on. We could update the workflow to process a different branch than it is run on, but that's beyond the scope of this.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmdefries nmdefries merged commit f7dae9d into dev Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants