Skip to content

only trigger workflow on push to dev #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

only trigger workflow on push to dev #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ name: CI

# Controls when the action will run.
on:
# Triggers the workflow on push or pull request events but only for the dev branch
# Triggers the workflow on push to the dev branch
push:
branches: [ dev ]
pull_request:
branches: [ dev ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a sanity check / unit test that we can still do here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to consider it in the scope of this PR, but some sort of check would be good. Perhaps https://github.com/jimhester/lintr with check syntax checking to start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I will add an issue for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also https://devtools.r-lib.org/reference/check.html


# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
Expand All @@ -35,4 +34,4 @@ jobs:
# Runs a single command using the runners shell
- name: Build and deploy dashboard docker image
run: |
make deploy_dashboard
make deploy_dashboard