Changes the behavior of Nginx when configured to serve static files #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AGE` in the production context to serve at `/signals/static/...`. This uses a regex to match on anyting that comes before `/static`, and then capture anything after into `$1` so that we can pass that as a file path to properly load the static files. Previously this only worked when we were server at the bare URL, but now it works when we are serving at `/signals/` (or potentially other URL "prefixes") as well.
…y config, as well as some notes about using the `MAIN_PAGE` env var. These options are typically only going to be used in production/non-dev environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly modifies the location block that Nginx uses when serving static files in the production/non-dev context. Also includes updates to the README about the possible ways to run a prod-like (ie serving static files via Nginx) locally.