Added error pages handlers #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added BadRequestErrorView, ForbiddenErrorView, NotFoundErrorView, and InternalServerErrorView classes to base/views.py - Modified signal_documentation/urls.py to include the error views as handlers for HTTP errors - Added 400.html, 403.html, 404.html, and 500.html templates to the templates directory - Added error.html template to the templates directory as a base for all error pages.
krivard
reviewed
Jun 16, 2023
src/templates/400.html
Outdated
| <h1>400</h1> | ||
| <h2>Bad Request.</h2> | ||
| <a class="btn" href="{% url 'signals' %}">Back to home</a> | ||
| <img src="{% static 'assets/img/not-found.svg' %}" class="img-fluid py-5" alt="Bad Request."> |
There was a problem hiding this comment.
What does the assets/img/not-found.svg image look like?
src/templates/error.html
Outdated
Comment on lines
11
to
13
| <title>Not Found 404</title> | ||
| <meta content="Not Found 404" name="description"> | ||
| <meta content="HTML, CSS, JavaScript" name="keywords"> |
There was a problem hiding this comment.
Check my understanding:
No matter what the error is (404, but also 400, 403, and 500) the title and metadata will say 404?
There was a problem hiding this comment.
I made meta empty
- Modified src/templates/400.html to update the image source for bad request error - Modified src/templates/403.html to update the image source for forbidden error - Modified src/templates/500.html to update the image source for internal server error - Modified src/templates/error.html to remove title and meta description and keywords
krivard
reviewed
Jun 20, 2023
I haven't pushed assets directory before, it includes files needed for bootstrap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in this PR include: