Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for Katie's departure #1224

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Jul 21, 2023

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Convert review assignments to assignees and switch from Katie to george. Review assignments are handled through the release-runner rotation.

@krivard krivard requested a review from melange396 July 21, 2023 17:41
@netlify
Copy link

netlify bot commented Jul 21, 2023

Preview link ready!

Name Link
🔨 Latest commit c9834e6
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/64bea4511666a30008c8ae07
😎 Deploy Preview https://deploy-preview-1224--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krivard krivard marked this pull request as draft July 21, 2023 17:49
@krivard krivard marked this pull request as ready for review July 21, 2023 17:56
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, 2 small things i noticed re: comments

.github/workflows/create_release.yml Show resolved Hide resolved
.github/workflows/update_gdocs_data.yml Show resolved Hide resolved
Co-authored-by: melange396 <george.haff@gmail.com>
@krivard krivard merged commit 7f0fbb2 into dev Jul 24, 2023
@krivard krivard deleted the krivard/departure-workflows branch July 24, 2023 17:23
@minhkhul minhkhul mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants