Skip to content

fix upload for simple cases #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2022
Merged

fix upload for simple cases #20

merged 5 commits into from
Aug 25, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 25, 2022

closes #18

test case:

a,date,v
1,2022-01-01,1
1,2022-01-02,2
1,2022-01-03,3
1,2022-01-04,4
1,2022-01-05,3

need different file to test more

based on #19

@sgratzl sgratzl added the bug label Aug 25, 2022
@sgratzl sgratzl requested a review from krivard August 25, 2022 03:17
@sgratzl sgratzl self-assigned this Aug 25, 2022
krivard
krivard approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible; will wait for you to confirm using Jingjing's csv

@sgratzl
Copy link
Member Author

sgratzl commented Aug 25, 2022

looks like this with the test file:

image

@sgratzl sgratzl merged commit 81bd550 into dev Aug 25, 2022
@sgratzl sgratzl deleted the sgatzl/upload_fix branch August 25, 2022 21:15
@krivard krivard mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sgratzl sgratzl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import file using the current EpiVis system
2 participants
@sgratzl @krivard