Skip to content

improve build and fixes for latest blogdown #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 27, 2021
Merged

improve build and fixes for latest blogdown #229

merged 6 commits into from
Jan 27, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jan 23, 2021

  • configure action to just rebuild files which md5 has changed
  • upload the compiled blog files as an action artifact
  • since blogdown doesn't seem to proper render the ref and apiref shortcodes anymore, I created a different version rendering the whole link: apireflink and reflink, e.g., r blogdown::shortcode_html("reflink", "2020-08-26-fb-survey", "Facebook Post")

-> recompiled everything and it is back to working

@sgratzl sgratzl self-assigned this Jan 23, 2021
tildechris
tildechris approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like solid improvements to the authoring experience. LGTM.

Aside - why do we need to check 3rd party libs into /static/rmarkdown-libs

@sgratzl
Copy link
Member Author

sgratzl commented Jan 27, 2021

Aside - why do we need to check 3rd party libs into /static/rmarkdown-libs

r markdown is generating and managing those.

@sgratzl sgratzl merged commit d852b95 into blog/holiday-surveys Jan 27, 2021
@sgratzl sgratzl deleted the sgratzl/holiday-fixes branch January 27, 2021 14:50
@sgratzl sgratzl mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tildechris tildechris tildechris approved these changes

@capnrefsmmat capnrefsmmat Awaiting requested review from capnrefsmmat

Assignees

@sgratzl sgratzl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @tildechris