Skip to content

prepare for correlation page #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021
Merged

prepare for correlation page #305

merged 3 commits into from
Apr 15, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 5, 2021

adds a new page and menu entry for cmu-delphi/www-covidcast#878

@sgratzl sgratzl requested a review from krivard April 5, 2021 12:07
@sgratzl sgratzl self-assigned this Apr 5, 2021
@netlify
Copy link

netlify bot commented Apr 5, 2021

Deploy preview for cmu-delphi-main ready!

Built with commit 02421ae

https://deploy-preview-305--cmu-delphi-main.netlify.app

@krivard
Copy link
Contributor

krivard commented Apr 5, 2021

"Explore correlations" appears in the menu, but clicking it brings you to the overview page instead. is that intentional?

@sgratzl
Copy link
Member Author

sgratzl commented Apr 5, 2021

the correlation isn't part of the COVDIcast yet. Thus, for now it falls back to its default mode. Once we merge cmu-delphi/www-covidcast#878 and release it, it should show the correct mode

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard
Copy link
Contributor

krivard commented Apr 5, 2021

(waiting to merge until cmu-delphi/www-covidcast#878 is ready, just in case we want to sneak something else out before then)

Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@sgratzl sgratzl merged commit e0eda3f into dev Apr 15, 2021
@sgratzl sgratzl deleted the sgratzl/correlationpage branch April 15, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants