Skip to content

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jul 1, 2021

use the new CTIS name where appropriate

@sgratzl sgratzl added the content label Jul 1, 2021
@sgratzl sgratzl self-assigned this Jul 1, 2021
@netlify
Copy link

netlify bot commented Jul 1, 2021

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: e326ff7

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/60e8c2946dea7d0007c1a8a7

😎 Browse the preview: https://deploy-preview-397--cmu-delphi-main.netlify.app/covidcast/surveys

@sgratzl sgratzl requested review from krivard and WichadaLMK July 2, 2021 07:01
@krivard
Copy link
Contributor

krivard commented Jul 2, 2021

@WichadaLMK do we have guidance on whether "CTIS Survey" is discouraged (survey survey) or fine?

@WichadaLMK
Copy link

WichadaLMK commented Jul 2, 2021 via email

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. I agree that "CTIS Survey Dashboard" is like having an ATM Machine Dashboard; maybe CTIS Results Dashboard would be nice and descriptive?

@WichadaLMK
Copy link

WichadaLMK commented Jul 6, 2021 via email

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional suggestions to ensure we say "COVID-19" instead of "COVID"

sgratzl and others added 10 commits July 7, 2021 10:01
Co-authored-by: Alex Reinhart <areinhar@stat.cmu.edu>
Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.71.1 to 0.72.3.
- [Release notes](https://github.com/fenneclab/hugo-bin/releases)
- [Commits](fenneclab/hugo-bin@v0.71.1...v0.72.3)

---
updated-dependencies:
- dependency-name: hugo-bin
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hugo-bin](https://github.com/fenneclab/hugo-bin) from 0.72.4 to 0.72.5.
- [Release notes](https://github.com/fenneclab/hugo-bin/releases)
- [Commits](fenneclab/hugo-bin@v0.72.4...v0.72.5)

---
updated-dependencies:
- dependency-name: hugo-bin
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.1.5...v2.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@sgratzl sgratzl changed the title rename to CTIS survey rename to CTIS Jul 7, 2021
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the Markdown, but looks fine otherwise (though I didn't review all the HTML changes that seem unrelated)

Comment on lines 83 to 92
[Stacy Kish](mailto:skish@andrew.cmu.edu)
Associate Director, Research Communications
Dietrich College
Carnegie Mellon University

### All other questions:

[Alex Reinhart](mailto:areinhar@stat.cmu.edu)
Assistant Teaching Professor
Department of Statistics & Data Science
[Alex Reinhart](mailto:areinhar@stat.cmu.edu)
Assistant Teaching Professor
Department of Statistics & Data Science
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing whitespace in the Markdown is actually essential here: two trailing spaces makes Markdown include line breaks instead of merging into one paragraph

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding in magic whitespace...

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 71d7791 into dev Jul 9, 2021
@krivard krivard deleted the sgratzl/survey_rename branch July 9, 2021 21:47
@krivard krivard mentioned this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants