Skip to content

Conversation

Ananya-Joshi
Copy link
Contributor

Adding a blog post with Tara and updating the IJCAI publication for FlaSH

@Ananya-Joshi
Copy link
Contributor Author

I am not sure how to debug this issue, but is it a problem with Hugo? https://discourse.gohugo.io/t/nil-pointer-evaluating-resource-resource-resize-in-version-0-57-0/20208/4

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit 189a3b8
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/65a6a09c1d2ee60007a46cb8
😎 Deploy Preview https://deploy-preview-904--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ananya-Joshi Ananya-Joshi marked this pull request as draft December 22, 2023 21:01
@Ananya-Joshi
Copy link
Contributor Author

Images are still not loading

@Ananya-Joshi Ananya-Joshi marked this pull request as ready for review December 22, 2023 21:29
@Ananya-Joshi
Copy link
Contributor Author

@rlunde @carlynvandyke @melange396

Happy new year everyone ! Would love to get your suggestions and comments on this blog so that it is ready to push.

@rlunde
Copy link
Contributor

rlunde commented Jan 3, 2024

Two tiny nitpicks in the last section:
"Overall, Changepoint detection is a powerful tool identify early indicators." - should it be "to identify" rather than "identify"?
also, should "lagingness" be "lagginess"? (Google didn't find the former when I looked)

@Ananya-Joshi
Copy link
Contributor Author

Two tiny nitpicks in the last section: "Overall, Changepoint detection is a powerful tool identify early indicators." - should it be "to identify" rather than "identify"? also, should "lagingness" be "lagginess"? (Google didn't find the former when I looked)

Thank you for those fixes! I just changed them and hopefully made the leading/lagging sentence a bit more clear (but please let me know what you think!)

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive got a number of suggestions that you can take or leave, but it looks great!

also, this is probably not a big deal, but it might not be completely future-proof if our stylesheets change: in the blog article, image3.png and image5.png do not have transparent backgrounds, but images 1, 2, and 4 do (and none of those outside the article have transparency).

- **On-time**: The major indicator changepoints appear within a week of the ground truth changepoints
- **Late**: The major indicator changepoints lag behind the ground truth changepoints by more than a week.

As we expected each wave of the pandemic to last around four weeks, we necessitate that any major indicator changepoints found with a distance greater than 28 days to the nearest ground truth changepoint have no relationship with the ground truth changepoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure i understand this... what do you mean by "necessitate"? are you saying that any indicator that exhibits this behavior gets classified into "inconsistent/variable" or "undetermined" categories that you talk about later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added some clarification:

As we expect COVID dynamics (like waves) to last around four weeks, if any major indicator changepoints is more than 28 days away from the nearest ground truth changepoint, it is likely a changepoint from an unrelated phenomena. Therefore, we only consider changepoints to have a leading or lagging relationship if the major indicator changepoint is within 28 days from a ground truth changepoint.

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better! id also change changepoints is to changepoint is

Ananya-Joshi and others added 11 commits January 4, 2024 09:17
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
@melange396
Copy link
Contributor

in the preview, you can see that now image1.png has a black line on the top edge, and image4.png has lines on the top and right edges :( ... is that from doing a screencap?

@Ananya-Joshi
Copy link
Contributor Author

Oops yes - should I revert to the other images - Tara generated them so I'm not sure if there's an easy way to add back the background without the source without screen capture. What do you think would be best?

@melange396
Copy link
Contributor

melange396 commented Jan 4, 2024

What do you think would be best?

im not sure... you can either go back to the transparent ones or redo the screencaps, or i think its possible to export the png without the alpha channel. let me try that and get back to you.

EDITED TO ADD: that worked! ill send them to you in slack (because im lazy and thats easier than doing a PR into your fork!)

@Ananya-Joshi
Copy link
Contributor Author

They look great - thank you George !

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@melange396 melange396 merged commit a4cc779 into cmu-delphi:dev Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants