Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini enhanced error handling; test file #29

Closed
wants to merge 13 commits into from
Closed

ini enhanced error handling; test file #29

wants to merge 13 commits into from

Conversation

utoddl
Copy link
Contributor

@utoddl utoddl commented Sep 9, 2017

This enhances error handling in ".ini" files, and creates "test/ini-test.ini". The "test" directory should contain example files demonstrating features and problematic issues with an eye toward regression testing as new features and bug fixes are implemented. In only has the ini-test.ini file at the moment, but this should expand over time.

@utoddl utoddl mentioned this pull request Sep 9, 2017
@cmur2
Copy link
Owner

cmur2 commented Sep 10, 2017

This is a great idea @utoddl - thanks for going ahead and proposing a test case for INI files. I think manually checking the test files for weird highlighting is the best of what we can achieve with joe for now although I would really like some semi-automatic way in the future... comparing against screenshots or something.

I'm currently a bit busy but will merge when I have some free time since I also wanted to restructure repo a bit.

@utoddl
Copy link
Contributor Author

utoddl commented Sep 10, 2017

Glad that idea appeals to you.

I also put a mention of the license directly in the .jsf and the test file. I found reading about the licenses confusing when trying to figure out which applied to specific files, especially once those file are "in the wild". Some of them are shipped with ne, which also uses joe's syntax engine, so having the license in the file is a big help. Leaves in the wind, etc.

@cmur2
Copy link
Owner

cmur2 commented Oct 4, 2017

Merged in 13cfbdc.

@cmur2 cmur2 closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants